Repository navigation
StorageManager tech debt: raw types and unchecked casts - #14560
Open
DaanHoogland wants to merge 1 commit into
Open
DaanHoogland wants to merge 1 commit into
DaanHoogland wants to merge 1 commit into
Conversation
1 task done
7 tasks done
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ghi12316-storage-exceptions #14560 +/- ##
=================================================================
- Coverage 20.78% 20.78% -0.01%
+ Complexity 21932 21929 -3
=================================================================
Files 6496 6496
Lines 591502 591486 -16
Branches 72568 72566 -2
=================================================================
- Hits 122963 122956 -7
+ Misses 455192 455185 -7
+ Partials 13347 13345 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DaanHoogland
changed the title
DaanHoogland
force-pushed
the
ghi12316-storage-rawtypes
branch
from
November 6, 2026 11:36
9523aad to
aebb3bb
Compare
Part of #12316 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DaanHoogland
force-pushed
the
ghi12316-storage-rawtypes
branch
from
November 6, 2026 15:08
aebb3bb to
585204c
Compare
DaanHoogland
changed the title
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.90% |
| Branch coverage | 20.23% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #14559
Description
Removes all
rawtypesanduncheckedjavac warnings in the touched storage files (13 + 11 on main, 0 after):detailsMAP parameters inAddSecondaryStorageCmd,AddImageStoreCmd,CreateStoragePoolCmdandUpdateStoragePoolCmdare typedMap<String, ? extends Map<String, String>>, asCreateSecondaryStagingStoreCmdalready does. That removes the casts in their accessors and inStorageManagerImpl.extractApiParamAsMap.AddImageStoreCmd.setDetailsdeclaredMap<String, String>but is given the unpacked (nested) map, so its type is corrected. The unusedUpdateStoragePoolCmd.setDetailsis removed.CollectionUtils/MapUtilsswitch to commons-collections4, whose typedintersectionmakes the(List<String>)casts unnecessary.@SuppressWarnings.Part of #12316
Types of changes
🤖 Generated with Claude Code